Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Confidential compute changes - 2022-10-01-preview #437

Merged
merged 11 commits into from
Feb 1, 2023
Merged

feat: Confidential compute changes - 2022-10-01-preview #437

merged 11 commits into from
Feb 1, 2023

Conversation

fnuarnav
Copy link
Collaborator

Allow user to specify Confidential container sku and specify ConfidentialComputeCcePolicy via annotations

@fnuarnav fnuarnav temporarily deployed to test January 27, 2023 07:34 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test January 27, 2023 07:35 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test January 27, 2023 07:39 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test January 27, 2023 07:40 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test January 27, 2023 09:33 — with GitHub Actions Inactive
@helayoty helayoty mentioned this pull request Jan 27, 2023
Closed
@helayoty helayoty added this to the 1.5.0 milestone Jan 27, 2023
@fnuarnav fnuarnav temporarily deployed to test January 29, 2023 00:13 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test January 29, 2023 00:13 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2023 •
edited
Loading

Codecov Report

Merging #437 (53c2e4c) into master (0c76852) will increase coverage by 1.25%.
The diff coverage is 51.69%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
+ Coverage   42.91%   44.16%   +1.25%     
==========================================
  Files          50       50              
  Lines        5735     5898     +163     
==========================================
+ Hits         2461     2605     +144     
- Misses       3017     3038      +21     
+ Partials      257      255       -2
Impacted Files Coverage Δ
pkg/featureflag/feature_flag.go 75.00% <ø> (+20.00%) ⬆️
pkg/network/aci_network.go 20.43% <7.74%> (-6.10%) ⬇️
pkg/auth/auth.go 60.32% <44.68%> (-6.35%) ⬇️
pkg/metrics/metrics.go 75.18% <57.14%> (-1.56%) ⬇️
pkg/provider/aci_volumes.go 45.19% <66.66%> (ø)
pkg/provider/aci.go 45.79% <77.05%> (+11.90%) ⬆️
pkg/provider/containergroup_to_pod.go 75.00% <85.71%> (-0.29%) ⬇️
pkg/analytics/analytics.go 64.70% <100.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

helayoty
helayoty reviewed Jan 30, 2023
View reviewed changes
e2e/confidential_container_test.go Show resolved Hide resolved
e2e/fixtures/confidential_container_pod.yml Outdated Show resolved Hide resolved
pkg/provider/aci.go Outdated Show resolved Hide resolved
pkg/provider/aci.go Outdated Show resolved Hide resolved
@fnuarnav fnuarnav temporarily deployed to test February 1, 2023 18:07 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test February 1, 2023 18:07 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test February 1, 2023 18:50 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test February 1, 2023 18:50 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test February 1, 2023 20:04 — with GitHub Actions Inactive
@helayoty
Copy link
Member

helayoty commented Feb 1, 2023

lgtm 🚢

@helayoty helayoty enabled auto-merge (squash) February 1, 2023 20:34
@helayoty helayoty merged commit f91b7e4 into virtual-kubelet:master Feb 1, 2023
helayoty pushed a commit that referenced this pull request Feb 7, 2023
@fnuarnav @helayoty
feat: ACI Confidential compute (#437)
6d9a479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mainaksarcar mainaksarcar mainaksarcar left review comments

@helayoty helayoty helayoty approved these changes

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo Fei-Guo is a code owner

Assignees
No one assigned
Labels
kind/feature
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fnuarnav @codecov-commenter @helayoty @mainaksarcar